Adding host as a configurable variable#84
Open
MillsyBot wants to merge 1 commit intomendhak:masterfrom
Open
Conversation
Owner
|
Hi thanks for the PR, could you have a look at the tests, they don't seem to be passing for me. I tried running ./tests.sh locally but it fails at the different hostnames test. I sometimes see "Different hostnames test failed." I also tried adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to run this container in
hostmode bypassing the docker bridge. This PR will add 2 new variablesHTTP_HOSTandHTTPS_HOSTto theDockerfileso that the user can modify the bind statements and allow for this. I added a rudimentary test to the existing suite to ensure the bind was happening properly.Great work, this is an awesome container.